feat: Add active external Visio connector to profile property settings list - EXO-69942_68649 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s list - EXO-69942 This commit adds the external Visio connectors active for users to the list of profile property settings.
IlhemEssaadi
changed the title
rdenarie
requested changes
Feb 28, 2024
|
|
||
| } | ||
|
|
||
| @Override | ||
| public ExternalVisioConnector createExternalVisioConnector(ExternalVisioConnectorEntity externalVisioConnectorEntity) { | ||
| public ExternalVisioConnector createExternalVisioConnector(ExternalVisioConnectorEntity externalVisioConnectorEntity) throws ObjectAlreadyExistsException { |
There was a problem hiding this comment.
why throwing the error here ?
if the setting property exists, so it is ok, catch the error, log a warn, and continue.
No need to propagate the error
| @@ -76,7 +85,8 @@ private void processUpdatedExternalVisioConnectors(List<ExternalVisioConnector> | |||
| }); | |||
| } | |||
|
|
|||
| public ExternalVisioConnector updateExternalVisioConnector(ExternalVisioConnectorEntity externalVisioConnectorEntity) throws ObjectNotFoundException { | |||
| public ExternalVisioConnector updateExternalVisioConnector(ExternalVisioConnectorEntity externalVisioConnectorEntity) throws ObjectNotFoundException, | |||
There was a problem hiding this comment.
same here, no need to propagate the errror
Already treated in the updateExternalVisioConnector method. |
rdenarie
approved these changes
Feb 29, 2024
IlhemEssaadi
added a commit
that referenced
this pull request
Mar 4, 2024
…s list - EXO-69942_68649 (#16) This commit adds the external Visio connectors active for users to the list of profile property settings.
IlhemEssaadi
added a commit
that referenced
this pull request
Mar 4, 2024
…s list - EXO-69942_68649 (#16) This commit adds the external Visio connectors active for users to the list of profile property settings.
azayati
pushed a commit
that referenced
this pull request
Mar 6, 2024
…s list - EXO-69942_68649 (#16) This commit adds the external Visio connectors active for users to the list of profile property settings.
IlhemEssaadi
added a commit
that referenced
this pull request
Mar 7, 2024
…s list - EXO-69942_68649 (#16) This commit adds the external Visio connectors active for users to the list of profile property settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the external Visio connectors active for users to the list of profile property settings.